Skip to content

Conversation

@bpintea
Copy link
Collaborator

@bpintea bpintea commented Jan 17, 2022

This adds support for the ES/SQL UNSIGNED_LONG type.

Values with this type can be received by the driver and forwarded to the
application as SQL_C_UBIGINT types. The driver will also accept
parameters of this type.

The driver-internal conversion to/from UNSIGNED_LONG is also supported.

The commit also adds logging of the name of the application loading the
driver.

This adds support for the ES/SQL UNSIGNED_LONG type.

Values with this type can be received by the driver and forwarded to the
application as SQL_C_UBIGINT types. The driver will also accept
parameters of this type.

The driver-internal conversion to/from UNSIGNED_LONG is also supported.

The commit also adds logging of the name of the application loading the
driver.
@bpintea bpintea added v8.2.0 and removed v8.1.0 labels Feb 3, 2022
@bpintea bpintea marked this pull request as ready for review February 3, 2022 20:20
Copy link
Collaborator

@edsavage edsavage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Add tests that pass and receive unsigned long values as arguments and
result-set values.
Change the CSV reconstitution to use the indices with given mapping
(rather then all keywords).
When at the end of a tagged value, the CBOR parser no longer needs to be
skipping the end-of-tag value, since the tagged value won't be inspected
any further.
@bpintea bpintea merged commit d165048 into elastic:master Feb 24, 2022
@bpintea bpintea deleted the enh/unsigned_long branch February 24, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants