Tests: Skip Version.CURRENT for static bwc indexes #10293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjernst
added
>test
Contributor
There was a problem hiding this comment.
can we have a comment as to why we do this?
Contributor
There was a problem hiding this comment.
maybe we should now have a method
public boolean skipVersion(Version) {
return a // foo
|| b // bar
|| c; // baz
}
seems simpler?
Member
Author
There was a problem hiding this comment.
I think a function is overkill, having the logic in the loop is nice and direct. I added comments.
Contributor
|
LGTM. Left one minor comment. |
The current version is normally a snapshot while in development. However, when the release process changes the snapshot flag to false, this causes the static bwc tests to fail because they cannot find an index for the current version. Instead, this change skips the current version, because there is no need to test a verion's bwc against itself. closes elastic#10292 closes elastic#10293
rjernst
force-pushed
the
fix/static-bwc-skip-current
branch
from
cb94f80 to
96fa466
Compare
rjernst
added a commit
that referenced
this pull request
Apr 4, 2015
The current version is normally a snapshot while in development. However, when the release process changes the snapshot flag to false, this causes the static bwc tests to fail because they cannot find an index for the current version. Instead, this change skips the current version, because there is no need to test a verion's bwc against itself. closes #10292 closes #10293 Conflicts: src/test/java/org/elasticsearch/bwcompat/OldIndexBackwardsCompatibilityTests.java
rjernst
added a commit
that referenced
this pull request
Apr 4, 2015
The current version is normally a snapshot while in development. However, when the release process changes the snapshot flag to false, this causes the static bwc tests to fail because they cannot find an index for the current version. Instead, this change skips the current version, because there is no need to test a verion's bwc against itself. closes #10292 closes #10293 Conflicts: src/test/java/org/elasticsearch/bwcompat/OldIndexBackwardsCompatibilityTests.java
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
The current version is normally a snapshot while in development. However, when the release process changes the snapshot flag to false, this causes the static bwc tests to fail because they cannot find an index for the current version. Instead, this change skips the current version, because there is no need to test a verion's bwc against itself. closes elastic#10292 closes elastic#10293 Conflicts: src/test/java/org/elasticsearch/bwcompat/OldIndexBackwardsCompatibilityTests.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version is normally a snapshot while in development.
However, when the release process changes the snapshot flag to false,
this causes the static bwc tests to fail because they cannot
find an index for the current version. Instead, this change
skips the current version, because there is no need to test
a verion's bwc against itself.
closes #10292