-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Yaml tests for standard retriever #104482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pinging @elastic/es-search (Team:Search) |
search: | ||
index: animals | ||
body: | ||
fields: [ "name", "count" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize we never talked about it, but should fields
be a part of a retriever, similar how sort
is a part of retriever
? Or is this wrong to think this way because fields
is applicable for the final fetch phase?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think fields continue to make the most sense as a global value for the final result set because I don't know how you would resolve it in a simple way for multiple retrievers potentially.
version: ' - 8.11.99' | ||
reason: 'kNN retriever added in 8.12' | ||
version: ' - 8.12.99' | ||
reason: 'classic retriever added in 8.12' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should the reason be about 8.13
version, may be we can say retrievers were added in 8.13
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jdconrad Thanks Jack, the changes look good to me.
@mayya-sharipova Thanks for the review. I'll merge as soon as CI passes. |
This change does the following: