Skip to content

Conversation

jdconrad
Copy link
Contributor

This change does the following:

  • renames the classic retriever to standard retriever
  • adds support for (pre) filter to the standard retriever
  • adds yaml tests for the standard retriever that covers all of the parse fields

@jdconrad jdconrad added >non-issue :Search Relevance/Ranking Scoring, rescoring, rank evaluation. v8.13.0 labels Jan 17, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Search Meta label for search team label Jan 17, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

search:
index: animals
body:
fields: [ "name", "count" ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize we never talked about it, but should fields be a part of a retriever, similar how sort is a part of retriever? Or is this wrong to think this way because fields is applicable for the final fetch phase?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think fields continue to make the most sense as a global value for the final result set because I don't know how you would resolve it in a simple way for multiple retrievers potentially.

version: ' - 8.11.99'
reason: 'kNN retriever added in 8.12'
version: ' - 8.12.99'
reason: 'classic retriever added in 8.12'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the reason be about 8.13 version, may be we can say retrievers were added in 8.13?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Fixed.

Copy link
Contributor

@mayya-sharipova mayya-sharipova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdconrad Thanks Jack, the changes look good to me.

@jdconrad
Copy link
Contributor Author

@mayya-sharipova Thanks for the review. I'll merge as soon as CI passes.

@jdconrad jdconrad merged commit 90e2d36 into elastic:retrievers Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>non-issue :Search Relevance/Ranking Scoring, rescoring, rank evaluation. Team:Search Meta label for search team v8.13.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants