Skip to content

Conversation

@mayya-sharipova
Copy link
Contributor

@mayya-sharipova mayya-sharipova commented Jul 5, 2024

Bit vector tests were failing in cases where an index has more than 1 shards. For error cases when we expected a failure of the whole request, shards with empty documents returned success and the whole request unexpectedly returned 200.

Ensuring that index contains only 1 shard fixes these failures.

Closes #110290, #110291

Bit vector tests were failing in cases where an index has more than 1 shards.
For error cases when we expected a failure of the whole request, shards
with empty documents returned success and the whoel request unexpectedly returned 200.

Ensuring that index contains only 1 shard fixes these failures.

Closes elastic#110290, elastic#110291
@mayya-sharipova mayya-sharipova added >test Issues or PRs that are addressing/adding tests :Search Relevance/Vectors Vector search v8.15.0 v8.16.0 v8.15.1 labels Jul 5, 2024
@mayya-sharipova mayya-sharipova requested a review from a team as a code owner July 5, 2024 12:39
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@elasticsearchmachine elasticsearchmachine added the Team:Search Meta label for search team label Jul 5, 2024
Copy link
Member

@carlosdelest carlosdelest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.15

mayya-sharipova added a commit to mayya-sharipova/elasticsearch that referenced this pull request Jul 5, 2024
Bit vector tests were failing in cases where an index has more than 1 shards.
For error cases when we expected a failure of the whole request, shards
with empty documents returned success and the whoel request unexpectedly returned 200.

Ensuring that index contains only 1 shard fixes these failures.

Closes elastic#110290, elastic#110291
mayya-sharipova added a commit that referenced this pull request Jul 5, 2024
Bit vector tests were failing in cases where an index has more than 1 shards.
For error cases when we expected a failure of the whole request, shards
with empty documents returned success and the whoel request unexpectedly returned 200.

Ensuring that index contains only 1 shard fixes these failures.

Closes #110290, #110291
tvernum pushed a commit that referenced this pull request Feb 25, 2025
Bit vector tests were failing in cases where an index has more than 1 shards.
For error cases when we expected a failure of the whole request, shards
with empty documents returned success and the whoel request unexpectedly returned 200.

Ensuring that index contains only 1 shard fixes these failures.

Closes #110290, #110291
tvernum pushed a commit that referenced this pull request Feb 25, 2025
Bit vector tests were failing in cases where an index has more than 1 shards.
For error cases when we expected a failure of the whole request, shards
with empty documents returned success and the whoel request unexpectedly returned 200.

Ensuring that index contains only 1 shard fixes these failures.

Closes #110290, #110291
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged :Search Relevance/Vectors Vector search Team:Search Meta label for search team >test Issues or PRs that are addressing/adding tests v8.15.0 v8.15.1 v8.16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] LangPainlessClientYamlTestSuiteIT test {yaml=painless/146_dense_vector_bit_basic/Cosine Similarity is not supported} failing

3 participants