ESQL: Tighten assertion on Block
#112367
Merged
ESQL: Tighten assertion on Block
#112367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tightens the invariant on `Block` - namely that there are no `0` length positions, at least none tracked by the `firstValueIndexes` in `ArrayBlock` - instead, the only way a position can be `0` length is to have been created with `appendNull`. The only cause of these `0` length positions was ordinals blocks made by `BlockHash`. This reworks that infrastructure to instead create those with `appendNull`.
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
the
Team:Analytics
nik9000
commented
Aug 29, 2024
| * 2.0. | ||
| */ | ||
|
|
||
| package org.elasticsearch.compute.aggregation.blockhash; |
Member
Author
There was a problem hiding this comment.
This is really a rename and a rewrite, but it's enough of a rewrite git doesn't think of it that way.
alex-spies
approved these changes
Aug 30, 2024
Contributor
alex-spies
left a comment
alex-spies
left a comment
There was a problem hiding this comment.
LGTM, thanks @nik9000 !
Member
Author
|
Thanks @alex-spies ! |
cbuescher
pushed a commit
to cbuescher/elasticsearch
that referenced
this pull request
Sep 4, 2024
This tightens the invariant on `Block` - namely that there are no `0` length positions, at least none tracked by the `firstValueIndexes` in `ArrayBlock` - instead, the only way a position can be `0` length is to have been created with `appendNull`. The only cause of these `0` length positions was ordinals blocks made by `BlockHash`. This reworks that infrastructure to instead create those with `appendNull`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tightens the invariant on
Block- namely that there are no0length positions, at least none tracked by thefirstValueIndexesinArrayBlock- instead, the only way a position can be0length is to have been created withappendNull.The only cause of these
0length positions was ordinals blocks made byBlockHash. This reworks that infrastructure to instead create those withappendNull.