Add tracing http chunk handlers #112770
Merged
Add tracing http chunk handlers #112770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhl-b
added
>non-issue
:Distributed Coordination/Network
|
Pinging @elastic/es-distributed (Team:Distributed) |
Tim-Brooks
reviewed
Sep 12, 2024
|
I opened a fix for the test compile issue: #112842 |
Tim-Brooks
approved these changes
Sep 13, 2024
...ransport-netty4/src/main/java/org/elasticsearch/http/netty4/Netty4HttpRequestBodyStream.java
Show resolved
Hide resolved
| @Override | ||
| public void close() { | ||
| try { | ||
| stream.close(); |
There was a problem hiding this comment.
I think this will be called twice in normal operation? I think that is fine for those output streams. But you might check that is okay and mitigate with a closed field if necessary.
There was a problem hiding this comment.
Currently stream will call close only on exceptional case, like channel close. So it should happen once. We might want to change behaviour for normal case to always close stream at the end and remove "isLast" parameter from handler.
There was a problem hiding this comment.
I see that you made a change here, but from what I can tell the stream closes under non-exceptional circumstances too. (Which seems correct to me. It would be odd if it did not close.)
0 = {StackTraceElement@19194} "java.base/java.lang.Thread.getStackTrace(Thread.java:2417)"
1 = {StackTraceElement@19195} "org.elasticsearch.http.netty4.Netty4HttpRequestBodyStream.close(Netty4HttpRequestBodyStream.java:128)"
2 = {StackTraceElement@19196} "org.elasticsearch.http.netty4.Netty4HttpRequest.release(Netty4HttpRequest.java:118)"
3 = {StackTraceElement@19197} "org.elasticsearch.http.DefaultRestChannel.sendResponse(DefaultRestChannel.java:91)"
4 = {StackTraceElement@19198} "org.elasticsearch.rest.RestController$DelegatingRestChannel.sendResponse(RestController.java:889)"
5 = {StackTraceElement@19199} "org.elasticsearch.rest.RestController$MeteringRestChannelDecorator.sendResponse(RestController.java:906)"
6 = {StackTraceElement@19200} "org.elasticsearch.rest.RestController$DelegatingRestChannel.sendResponse(RestController.java:889)"
7 = {StackTraceElement@19201} "org.elasticsearch.rest.RestController$ResourceHandlingHttpChannel.sendResponse(RestController.java:954)"
8 = {StackTraceElement@19202} "org.elasticsearch.rest.action.RestChunkedToXContentListener.processResponse(RestChunkedToXContentListener.java:40)"
9 = {StackTraceElement@19203} "org.elasticsearch.rest.action.RestChunkedToXContentListener.processResponse(RestChunkedToXContentListener.java:25)"
10 = {StackTraceElement@19204} "org.elasticsearch.rest.action.RestActionListener.onResponse(RestActionListener.java:36)"
11 = {StackTraceElement@19205} "org.elasticsearch.action.bulk.IncrementalBulkService$Handler$2.onResponse(IncrementalBulkService.java:195)"
12 = {StackTraceElement@19206} "org.elasticsearch.action.bulk.IncrementalBulkService$Handler$2.onResponse(IncrementalBulkService.java:188)"
13 = {StackTraceElement@19207} "org.elasticsearch.action.ActionListenerImplementations$RunBeforeActionListener.onResponse(ActionListenerImplementations.java:335)"
14 = {StackTraceElement@19208} "org.elasticsearch.action.ActionListener$3.onResponse(ActionListener.java:399)"
15 = {StackTraceElement@19209} "org.elasticsearch.action.ActionListener$3.onResponse(ActionListener.java:399)"
16 = {StackTraceElement@19210} "org.elasticsearch.tasks.TaskManager$1.onResponse(TaskManager.java:202)"
17 = {StackTraceElement@19211} "org.elasticsearch.tasks.TaskManager$1.onResponse(TaskManager.java:196)"
18 = {StackTraceElement@19212} "org.elasticsearch.action.ActionListenerImplementations$RunBeforeActionListener.onResponse(ActionListenerImplementations.java:335)"
19 = {StackTraceElement@19213} "org.elasticsearch.action.ActionListener$3.onResponse(ActionListener.java:399)"
20 = {StackTraceElement@19214} "org.elasticsearch.action.ActionListenerImplementations$RunBeforeActionListener.onResponse(ActionListenerImplementations.java:335)"
21 = {StackTraceElement@19215} "org.elasticsearch.action.ActionListener$3.onResponse(ActionListener.java:399)"
There was a problem hiding this comment.
right, completely forgot about Netty4HttpRequest.release
There was a problem hiding this comment.
And it's my doing, I implemented it for handling RestController exceptions that do not reach RestHandler. For example 400-bad-request. In that case need to close stream, while channel is still open.
Tim-Brooks
pushed a commit
that referenced
this pull request
Sep 17, 2024
Tim-Brooks
pushed a commit
that referenced
this pull request
Sep 17, 2024
Tim-Brooks
pushed a commit
that referenced
this pull request
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tracing handlers to HTTP stream. Also implement tracing handler for http-client-stats bytes counting and body logging. Added integ test for each.