Additional index settings provider validation #113838
Conversation
…nother index settings provider.
martijnvg
added
>non-issue
:Data Management/Indices APIs
elasticsearchmachine
added
Team:Data Management
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
|
Pinging @elastic/es-data-management (Team:Data Management) |
| templateAndRequestSettings, | ||
| combinedTemplateMappings | ||
| ); | ||
| validateAdditionalSettings(provider, newAdditionalSettings, additionalIndexSettings); |
There was a problem hiding this comment.
Here we validate the newAdditionalSettings against the additionalSettings seen so far and not values previously set by the user for example templateAndRequestSettings. Are these 2 settings sets disjoint ?
There was a problem hiding this comment.
The newAdditionalSettings variable contains any settings that the current index settings provider might have set. The additionalIndexSettings variable tracks any settings that any index settings provider may have set while looping over the list of index settings providers. The new validation requires that newAdditionalSettings cannot contain any settings that are already defined in additionalIndexSettings. So yes, these two Settings variables should be a disjoint.
|
Thanks Mary and Nhat for reviewing! |
martijnvg
added
the
auto-backport
Fail if an index settings provider adds a setting that was added by another index settings provider.
💚 Backport successful
|
Fail if an index settings provider adds a setting that was added by another index settings provider.
4 participants
Fail if an index settings provider adds a setting that was added by another index settings provider.