Skip to content

[CI] MixedClusterClientYamlTestSuiteIT test {p0=range/20_synthetic_source/Date range} failing - Removed Old Date range test because it's not longer validating useful code #114057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 25, 2024
Merged

[CI] MixedClusterClientYamlTestSuiteIT test {p0=range/20_synthetic_source/Date range} failing - Removed Old Date range test because it's not longer validating useful code #114057

merged 4 commits into from
Oct 25, 2024

Conversation

john-wagster
Copy link
Contributor

Related to: #114011
Related to: #113874
Related to: #112258

@john-wagster john-wagster added >test Issues or PRs that are addressing/adding tests v9.0.0 labels Oct 3, 2024
@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label Oct 3, 2024
@mayya-sharipova mayya-sharipova added :Search Foundations/Mapping Index mappings, including merging and defining field types and removed needs:triage Requires assignment of a team area label labels Oct 8, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch label Oct 8, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-foundations (Team:Search Foundations)

@john-wagster john-wagster added auto-backport Automatically create backport pull requests when merged v8.16.0 v8.17.0 backport labels Oct 23, 2024
@lkts
Copy link
Contributor

lkts commented Oct 23, 2024

Thanks!

andreidan
andreidan approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@andreidan andreidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this John

Can you please update the PR title and description to reflect the change? (i.e. removing not unmuting and the motivation behind the change)

Otherwise, LGTM

@john-wagster john-wagster changed the title [CI] MixedClusterClientYamlTestSuiteIT test {p0=range/20_synthetic_source/Date range} failing - UnMuting [CI] MixedClusterClientYamlTestSuiteIT test {p0=range/20_synthetic_source/Date range} failing - Removed Old Date range test because it's not longer validating useful code Oct 25, 2024
@john-wagster john-wagster merged commit d4ac705 into elastic:main Oct 25, 2024
16 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
❌ 8.16 Commit could not be cherrypicked due to conflicts
❌ 8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 114057

This was referenced Oct 25, 2024
Merged
Merged
Closed
jfreden pushed a commit to jfreden/elasticsearch that referenced this pull request Nov 4, 2024
@john-wagster @jfreden
[CI] MixedClusterClientYamlTestSuiteIT test {p0=range/20_synthetic_so…
a74a786 
…urce/Date range} failing - Removed Old `Date range` test because it's not longer validating useful code (elastic#114057)

unmuting test and removing bwc test to get mixedClusterTest working
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andreidan andreidan andreidan approved these changes

@lkts lkts lkts approved these changes

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged backport pending backport :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch >test Issues or PRs that are addressing/adding tests v8.16.0 v8.17.0 v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@john-wagster @elasticsearchmachine @lkts @andreidan @mayya-sharipova