Improve performance of LongObjectPagedHashMap#removeAndAdd and ObjectObjectPagedHashMap#removeAndAdd #114280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ObjectPagedHashMap#removeAndAdd
iverase
added
>non-issue
:Analytics/Aggregations
elasticsearchmachine
added
Team:Core/Infra
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
iverase
commented
Oct 8, 2024
| private T set(long key, T value) { | ||
| if (value == null) { | ||
| throw new IllegalArgumentException("Null values are not supported"); | ||
| } |
There was a problem hiding this comment.
Let's just assert it and don't waste time checking for it
original-brownbear
approved these changes
Oct 10, 2024
server/src/main/java/org/elasticsearch/common/util/LongObjectPagedHashMap.java
Show resolved
Hide resolved
iverase
added
the
auto-backport
|
@elasticmachine update branch |
|
@elasticmachine update branch |
💚 Backport successful
|
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Oct 10, 2024
…ObjectPagedHashMap#removeAndAdd (elastic#114280)
matthewabbott
pushed a commit
to matthewabbott/elasticsearch
that referenced
this pull request
Oct 10, 2024
…ObjectPagedHashMap#removeAndAdd (elastic#114280)
davidkyle
pushed a commit
to davidkyle/elasticsearch
that referenced
this pull request
Oct 13, 2024
…ObjectPagedHashMap#removeAndAdd (elastic#114280)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to what we did in #114199, lets remove some unnecessary manipulation of the keys in the method removeAndAdd.