[TEST] Add coverage for field caps and ES|QL to LogsDB QA testing #114505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkrik-es
added
>test
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
lkts
reviewed
Oct 10, 2024
|
|
||
| indexDocuments(documents); | ||
|
|
||
| // Excludes the FROM prefix. |
There was a problem hiding this comment.
It means that I forgot to remove it :)
|
|
||
| indexDocuments(documents); | ||
|
|
||
| final MatchResult matchResult = Matcher.matchSource() |
There was a problem hiding this comment.
The result of field caps is not source right? I think we should be using a generic matcher.
lkts
approved these changes
Oct 10, 2024
kkrik-es
added
auto-backport
💔 Backport failedThe backport operation could not be completed due to the following error: You can use sqren/backport to manually backport by running |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
kkrik-es
added a commit
to kkrik-es/elasticsearch
that referenced
this pull request
Oct 11, 2024
…astic#114505) * Add coverage for field caps and ES|QL to LogsDB QA testing * address comments * address comments * address comments (cherry picked from commit 34da953)
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 11, 2024
davidkyle
pushed a commit
to davidkyle/elasticsearch
that referenced
this pull request
Oct 13, 2024
…astic#114505) * Add coverage for field caps and ES|QL to LogsDB QA testing * address comments * address comments * address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #109800