[ESQL] Replace "::<type>" casts to functions in date CSV tests #114639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivancea
added
>test
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
bpintea
reviewed
Oct 11, 2024
| required_capability: date_diff_year_calendarial | ||
|
|
||
| ROW from="2023-12-31T23:59:59.999Z"::DATETIME, to="2024-01-01T00:00:00"::DATETIME | ||
| ROW from=TO_DATETIME("2023-12-31T23:59:59.999Z"), to=TO_DATETIME("2024-01-01T00:00:00") |
There was a problem hiding this comment.
The tests that require date_diff_year_calendarial could be kept as are (since that capability was added way past 8.15, when :: was introduced). But maybe better like this for consistency.
💚 Backport successful
|
ivancea
added a commit
to ivancea/elasticsearch
that referenced
this pull request
Oct 11, 2024
Fixes elastic#114613 Those tests were added with `::<type>` casts, which don't work in older versions. As they aren't testing anything around those casts, I'm replacing them with `TO_<TYPE>()` functions to let them work everywhere.
davidkyle
pushed a commit
to davidkyle/elasticsearch
that referenced
this pull request
Oct 13, 2024
Fixes elastic#114613 Those tests were added with `::<type>` casts, which don't work in older versions. As they aren't testing anything around those casts, I'm replacing them with `TO_<TYPE>()` functions to let them work everywhere.
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Oct 25, 2024
Fixes elastic#114613 Those tests were added with `::<type>` casts, which don't work in older versions. As they aren't testing anything around those casts, I'm replacing them with `TO_<TYPE>()` functions to let them work everywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #114613
Those tests were added with
::<type>casts, which don't work in older versions.As they aren't testing anything around those casts, I'm replacing them with
TO_<TYPE>()functions to let them work everywhere.