Updating text_similarity_reranker tests to account for the test_reranking_service #114945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmpailis
added
>test
elasticsearchmachine
added
the
Team:Search Relevance
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
benwtrent
approved these changes
Oct 17, 2024
pmpailis
added a commit
to pmpailis/elasticsearch
that referenced
this pull request
Oct 17, 2024
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 17, 2024
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Oct 25, 2024
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #114757
Yet another doc-dependant issue.. 😞 The issue this time is that in the "fake" reranker we deploy for tests, we assign a score to each document based on the order that it was received.
However, even if we sort the documents for the nested
standardretriever, we still sort based ondocon the shards in order to execute fetch phase, so the final order with which we call the inference service is actually based ondocand not on the original score.This is not an issue for a service that produces actual scores, but in this scenario where the final score is dependant on the position of the document in the inference request, it could cause issues.
Updating query clauses (for yet another time) + relaxing clause validation.