Make inline sort alias name a prefix match in testPushTopNInlineDistanceToSource #114984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigtaverner
added
>test
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
This reduces flakiness of this test.
craigtaverner
force-pushed
the
less_flaky_inlinesort_aliasname
branch
from
218f5cd to
afe7705
Compare
alex-spies
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
LGTM, thanks Craig!
Making the test more lenient is correct because ReplaceOrderByExpresionWithEval creates this weird $$order_by$0$1 attribute name and the last number comes from a static counter that is never reset. So the exact number will depend on what tests were executed before this one.
astefan
approved these changes
Oct 17, 2024
craigtaverner
added a commit
to craigtaverner/elasticsearch
that referenced
this pull request
Oct 17, 2024
…nceToSource (elastic#114984) * Make inline sort alias name a prefix match This reduces flakiness of this test. * Added comments on prefix check for variable name
craigtaverner
added a commit
to craigtaverner/elasticsearch
that referenced
this pull request
Oct 17, 2024
…nceToSource (elastic#114984) * Make inline sort alias name a prefix match This reduces flakiness of this test. * Added comments on prefix check for variable name
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Oct 25, 2024
…nceToSource (elastic#114984) * Make inline sort alias name a prefix match This reduces flakiness of this test. * Added comments on prefix check for variable name
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Nov 4, 2024
…nceToSource (elastic#114984) * Make inline sort alias name a prefix match This reduces flakiness of this test. * Added comments on prefix check for variable name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces flakiness of this test.