-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Unmute TestFeatureLicenseTrackingIT testFeatureTrackingInferenceModelPipeline #115340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine merge upstream |
|
Pinging @elastic/ml-core (Team:ML) |
davidkyle
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@elasticmachine merge upstream |
dan-rubinstein
added a commit
to dan-rubinstein/elasticsearch
that referenced
this pull request
Oct 28, 2024
…Pipeline (elastic#115340) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
dan-rubinstein
added a commit
to dan-rubinstein/elasticsearch
that referenced
this pull request
Oct 28, 2024
…Pipeline (elastic#115340) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
ioanatia
pushed a commit
to ioanatia/elasticsearch
that referenced
this pull request
Nov 4, 2024
…Pipeline (elastic#115340) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Nov 4, 2024
…Pipeline (elastic#115340) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was muted in this issue. The test was failing because the
.ml-annotations-000001index was found when checking that cleanup was completed properly as part of the ESSingleNodeTestCase assertion here). This index should be getting cleaned up but the ESSingleNodeTestCase class was not waiting for all index actions to complete before checking for successful cleanup. It seems like other tests were failing for a similar reason at the time after which a change was made to wait all index actions to complete. These changes should fix the failing test so we should be safe to unmute.I've run the following command multiple times locally and have not been able to reproduce this issue anymore: