Skip to content

Conversation

@dan-rubinstein
Copy link
Member

@dan-rubinstein dan-rubinstein commented Oct 22, 2024

This test was muted in this issue. The test was failing because the .ml-annotations-000001 index was found when checking that cleanup was completed properly as part of the ESSingleNodeTestCase assertion here). This index should be getting cleaned up but the ESSingleNodeTestCase class was not waiting for all index actions to complete before checking for successful cleanup. It seems like other tests were failing for a similar reason at the time after which a change was made to wait all index actions to complete. These changes should fix the failing test so we should be safe to unmute.

I've run the following command multiple times locally and have not been able to reproduce this issue anymore:

./gradlew ':x-pack:plugin:ml:internalClusterTest' --tests "org.elasticsearch.xpack.ml.integration.TestFeatureLicenseTrackingIT.testFeatureTrackingInferenceModelPipeline" -Druntime.java=21 -Dtests.iters=1000

@dan-rubinstein dan-rubinstein added :ml Machine learning Team:ML Meta label for the ML team >test Issues or PRs that are addressing/adding tests v9.0.0 v8.17.0 labels Oct 22, 2024
@elasticsearchmachine elasticsearchmachine added the external-contributor Pull request authored by a developer outside the Elasticsearch team label Oct 22, 2024
@dan-rubinstein
Copy link
Member Author

@elasticmachine merge upstream

@dan-rubinstein dan-rubinstein added v8.16.0 auto-backport Automatically create backport pull requests when merged labels Oct 24, 2024
@dan-rubinstein dan-rubinstein marked this pull request as ready for review October 24, 2024 19:34
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@davidkyle davidkyle removed the external-contributor Pull request authored by a developer outside the Elasticsearch team label Oct 25, 2024
Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dan-rubinstein
Copy link
Member Author

@elasticmachine merge upstream

@dan-rubinstein dan-rubinstein merged commit 7efa5a3 into elastic:main Oct 28, 2024
16 checks passed
dan-rubinstein added a commit to dan-rubinstein/elasticsearch that referenced this pull request Oct 28, 2024
…Pipeline (elastic#115340)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.16
8.x

dan-rubinstein added a commit to dan-rubinstein/elasticsearch that referenced this pull request Oct 28, 2024
…Pipeline (elastic#115340)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
elasticsearchmachine pushed a commit that referenced this pull request Oct 28, 2024
…Pipeline (#115340) (#115772)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
elasticsearchmachine pushed a commit that referenced this pull request Oct 28, 2024
…Pipeline (#115340) (#115773)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
ioanatia pushed a commit to ioanatia/elasticsearch that referenced this pull request Nov 4, 2024
…Pipeline (elastic#115340)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jfreden pushed a commit to jfreden/elasticsearch that referenced this pull request Nov 4, 2024
…Pipeline (elastic#115340)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged :ml Machine learning Team:ML Meta label for the ML team >test Issues or PRs that are addressing/adding tests v8.16.0 v8.17.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants