Fixing DatabaseNodeServiceIT testNonGzippedDatabase and testGzippedDatabase race condition #115463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tabase race condition
masseyke
added
>test
|
Pinging @elastic/es-data-management (Team:Data Management) |
elasticsearchmachine
added
the
Team:Data Management
|
What do you think about this version of things, @masseyke? It seems to pass reliably on my machine, but doesn't require a change to the source (it only fusses with the test code). |
It makes me slightly less uncomfortable than the previous version. So I saw we go for it. I've run it a bunch of times without any problems so far. |
💔 Backport failed
You can use sqren/backport to manually backport by running |
masseyke
added a commit
to masseyke/elasticsearch
that referenced
this pull request
Oct 25, 2024
…tabase race condition (elastic#115463) Co-authored-by: Joe Gallo <joegallo@gmail.com>
masseyke
added a commit
to masseyke/elasticsearch
that referenced
this pull request
Oct 25, 2024
…tabase race condition (elastic#115463) Co-authored-by: Joe Gallo <joegallo@gmail.com>
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Nov 4, 2024
…tabase race condition (elastic#115463) Co-authored-by: Joe Gallo <joegallo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every once in a while, DatabaseNodeService::checkDatabases gets called at just the wrong time and deletes the database we are using in these tests. This PR adds an assertBusy to retry when this happens.
Closes #113752
Closes #113821