Adding additional checks for IPInfo results #115481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masseyke
added
>test
Because it happens to always be called in a context where the database had already been copied. If that changes, somebody else can just add it back. 🤷
But you have to give it a null throwable in order to get the correct arity for that capability.
|
Since this is only tests, I'm adding the |
joegallo
added
auto-backport
masseyke
removed
the
auto-backport
masseyke
added
auto-backport
|
LOL, eventual consistency on the labels there. 😄 |
|
Pinging @elastic/es-data-management (Team:Data Management) |
masseyke
added a commit
to masseyke/elasticsearch
that referenced
this pull request
Oct 25, 2024
masseyke
added a commit
to masseyke/elasticsearch
that referenced
this pull request
Oct 25, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 25, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 25, 2024
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds checks that the data coming back from the reader doesn't change when we update our sample data, and that we know what we are handling vs what we are not.