Add challenge tests for logsdb that utilize stored source #115606
Conversation
lkts
added
>test
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
| } | ||
|
|
||
| @Override | ||
| public Response indexContenderDocuments(CheckedSupplier<List<XContentBuilder>, IOException> documentsSupplier) throws IOException { |
There was a problem hiding this comment.
This method exists in a base class, just a clean up.
| } | ||
|
|
||
| @Override | ||
| public Response indexContenderDocuments(CheckedSupplier<List<XContentBuilder>, IOException> documentsSupplier) throws IOException { |
There was a problem hiding this comment.
This method exists in a base class, just a clean up.
| } | ||
|
|
||
| void logsDbSettings(Settings.Builder builder) { | ||
| builder.put("index.mode", "logsdb"); |
There was a problem hiding this comment.
Noticed this oversight, it only impacted reindex tests.
| } | ||
|
|
||
| @Override | ||
| public void contenderSettings(Settings.Builder builder) { |
There was a problem hiding this comment.
I am wondering if we should just create base classes like
SyntheticSourceAbstractChallengeRestTest
DisableSourceAbstractChallengeRestTest
StoredSourceAbstractChallengeRestTest
where the setting is applied and we can just inherit from them.
There was a problem hiding this comment.
The thing is that sometimes baseline has stored source and sometimes the contender.
|
@elasticmachine update branch |
💔 Backport failedThe backport operation could not be completed due to the following error: You can use sqren/backport to manually backport by running |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
5 participants
No description provided.