Skip to content

[8.16] Correctly update search status for a nonexistent local index (#115138) #115612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2024
Merged

[8.16] Correctly update search status for a nonexistent local index (#115138) #115612

merged 1 commit into from
Oct 25, 2024

Conversation

@pawankartik-elastic
Copy link
Contributor

@pawankartik-elastic pawankartik-elastic commented Oct 24, 2024 •
edited
Loading

Backport

This will backport the following commits from main to 8.16:

@pawankartik-elastic
Correctly update search status for a nonexistent local index (elastic…
e154792 
…#115138)

* fix: correctly update search status for a nonexistent local index

* Check for cluster existence before updation

* Remove unnecessary `println`

* Address review comment: add an explanatory code comment

* Further clarify code comment

(cherry picked from commit ad9c5a0)
@pawankartik-elastic pawankartik-elastic mentioned this pull request Oct 24, 2024
Merged
@pawankartik-elastic pawankartik-elastic added >bug :Search Foundations/Search Catch all for Search Foundations Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch labels Oct 24, 2024
quux00
quux00 approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@quux00 quux00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quux00
Copy link
Contributor

quux00 commented Oct 25, 2024

buildkite test this

@pawankartik-elastic pawankartik-elastic merged commit dec43e3 into elastic:8.16 Oct 25, 2024
15 checks passed
@pawankartik-elastic pawankartik-elastic deleted the backport/8.16/pr-115138 branch October 25, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@quux00 quux00 quux00 approved these changes

Assignees

No one assigned

Labels

backport >bug :Search Foundations/Search Catch all for Search Foundations Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch v8.16.1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pawankartik-elastic @quux00 @elasticsearchmachine