Implement string parsing for the KQL parser. #115662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afoucret
added
>non-issue
auto-backport
elasticsearchmachine
added
the
Team:Search Relevance
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
afoucret
requested review from
a team,
ChrisHegarty,
carlosdelest,
ioanatia and
tteofili
tteofili
approved these changes
Oct 25, 2024
carlosdelest
approved these changes
Oct 25, 2024
x-pack/plugin/kql/src/main/java/org/elasticsearch/xpack/kql/parser/ParserUtils.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Carlos Delgado <6339205+carlosdelest@users.noreply.github.com>
kderusso
approved these changes
Oct 25, 2024
x-pack/plugin/kql/src/main/java/org/elasticsearch/xpack/kql/parser/ParserUtils.java
Outdated
Show resolved
Hide resolved
| if (preserveWildcards) { | ||
| StringBuilder escapedQuery = new StringBuilder(queryText.length()); | ||
| StringBuilder subpart = new StringBuilder(queryText.length()); | ||
| for (int i = 0; i < queryText.length(); i++) { |
There was a problem hiding this comment.
I think you could write this a little more readable, something like:
for (char currentChar : queryText.toCharArray()) {
if (currentChar == '*') {
escapedQuery.append(QueryParser.escape(subpart.toString())).append(currentChar);
subpart.setLength(0);
} else {
subpart.append(currentChar);
}
}
| StringBuilder subpart = new StringBuilder(queryText.length()); | ||
| for (int i = 0; i < queryText.length(); i++) { | ||
| char currentChar = queryText.charAt(i); | ||
| if (currentChar == '*') { |
There was a problem hiding this comment.
Nitpick - would be nice to use a constant for WILDCARD_CHAR
Co-authored-by: Kathleen DeRusso <kathleen.derusso@elastic.co>
afoucret
commented
Oct 25, 2024
x-pack/plugin/kql/src/main/java/org/elasticsearch/xpack/kql/parser/ParserUtils.java
Outdated
Show resolved
Hide resolved
afoucret
added a commit
to afoucret/elasticsearch
that referenced
this pull request
Oct 25, 2024
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 25, 2024
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implement text extraction for the KQL parser quoted and unquoted strings.