Skip to content

Remove "Use ELSER By Default For Semantic Text" Changelog Entry #115686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2024
Merged

Remove "Use ELSER By Default For Semantic Text" Changelog Entry #115686

merged 1 commit into from
Oct 25, 2024

Conversation

Mikep86
Copy link
Contributor

@Mikep86 Mikep86 commented Oct 25, 2024

Remove the "Use ELSER By Default For Semantic Text" changelog entry. This functionality is behind a feature flag, so it should not be publicized through the changelog.

@Mikep86 Mikep86 added >non-issue :Search Relevance/Vectors Vector search :SearchOrg/Relevance Label for the Search (solution/org) Relevance team >docs General docs changes labels Oct 25, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-eng (Team:SearchOrg)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-relevance (Team:Search - Relevance)

@Mikep86 Mikep86 requested a review from carlosdelest October 25, 2024 18:06
Samiul-TheSoccerFan
Samiul-TheSoccerFan approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@Samiul-TheSoccerFan Samiul-TheSoccerFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Quick question: Why do we need a separate PR when we are also reverting the same changelog from this PR? I can see the base branch in these two PRs are different. However, shouldn't all PRs go to the main and then backport to their required versions?

@kderusso
Copy link
Member

++ @Mikep86 I think that this can be closed in favor of #115684

@Mikep86
Copy link
Contributor Author

Mikep86 commented Oct 25, 2024 •
edited
Loading

@kderusso @Samiul-TheSoccerFan

#115684 applies only to the 8.x & 8.16 branches. Default ELSER for semantic text is already behind a feature flag for Serverless, so no need to take any logic changes from that PR.

However, the changelog entry remains in main, even though the feature is behind a feature flag. This PR fixes that.

kderusso
kderusso approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@kderusso kderusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying!

@Mikep86 Mikep86 merged commit 5e98251 into elastic:main Oct 25, 2024
6 checks passed
jfreden pushed a commit to jfreden/elasticsearch that referenced this pull request Nov 4, 2024
@Mikep86 @jfreden
Remove "Use ELSER By Default For Semantic Text" Changelog Entry (elas…
aada254 
…tic#115686)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kderusso kderusso kderusso approved these changes

@Samiul-TheSoccerFan Samiul-TheSoccerFan Samiul-TheSoccerFan approved these changes

@carlosdelest carlosdelest Awaiting requested review from carlosdelest

Assignees

No one assigned

Labels

>docs General docs changes >non-issue :Search Relevance/Vectors Vector search :SearchOrg/Relevance Label for the Search (solution/org) Relevance team v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Mikep86 @elasticsearchmachine @kderusso @Samiul-TheSoccerFan