ESQL: CCS skip_unavailable testing for non-matching index expressions under RCS2 #116846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quux00
added
>test
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
quux00
changed the title
jakelandis
approved these changes
Nov 18, 2024
| assertThat(e.getMessage(), containsString("on indices [employees_nomatch]")); | ||
| assertThat(e.getMessage(), containsString("security_exception")); | ||
|
|
||
| // TODO: in follow on PR, add support for throwing a VerificationException for this scenario - no exception is currently thrown |
There was a problem hiding this comment.
nit: can you remove "in a follow on PR", unless you plan to address immediately ? else, if in a year+ looking at the message appears that we forgot to do something important instead of a standard TODO which represents an area of improvement, but maybe not completely necessary.
quux00
added a commit
to quux00/elasticsearch
that referenced
this pull request
Nov 20, 2024
quux00
added a commit
to quux00/elasticsearch
that referenced
this pull request
Nov 20, 2024
quux00
added a commit
that referenced
this pull request
Nov 20, 2024
rjernst
pushed a commit
to rjernst/elasticsearch
that referenced
this pull request
Nov 20, 2024
alexey-ivanov-es
pushed a commit
to alexey-ivanov-es/elasticsearch
that referenced
this pull request
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-on PR for functionality added in #116348