Skip to content

Fix url in docs page #117009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2025
Merged

Fix url in docs page #117009

merged 1 commit into from
Jan 20, 2025

Conversation

hanjongho
Copy link

Fix Starting -> Stopping

In https://www.elastic.co/guide/en/elasticsearch/reference/current/security-basic-setup.html,
when click stopping link, It linked to the same url as the route next to it.(starting)

@github-actions GitHub Actions
Copy link
Contributor

Documentation preview:

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v8.16.2 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Nov 19, 2024
@hanjongho hanjongho changed the title Update security-basic-setup.asciidoc Fix url in docs page Nov 19, 2024
@gbanasiak gbanasiak added the >docs General docs changes label Nov 22, 2024
@elasticsearchmachine elasticsearchmachine added Team:Docs Meta label for docs team and removed needs:triage Requires assignment of a team area label labels Nov 22, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@leemthompo leemthompo self-assigned this Nov 22, 2024
leemthompo
leemthompo approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix :)

@leemthompo leemthompo added v8.14.0 v8.15.0 v8.17.0 v8.18.0 auto-backport Automatically create backport pull requests when merged labels Nov 22, 2024
@leemthompo leemthompo enabled auto-merge (squash) November 22, 2024 10:29
@hanjongho
Update security-basic-setup.asciidoc
dad45b3 
Fix Starting -> Stopping
auto-merge was automatically disabled January 19, 2025 10:37

Head branch was pushed to by a user without write access

@leemthompo
Copy link
Contributor

@elasticmachine test this

@leemthompo
Copy link
Contributor

run docs-build

@leemthompo leemthompo merged commit bf2e91d into elastic:8.16 Jan 20, 2025
7 checks passed
leemthompo pushed a commit to leemthompo/elasticsearch that referenced this pull request Jan 20, 2025
@hanjongho @leemthompo
Update security-basic-setup.asciidoc (elastic#117009)
47c3caf 
Fix Starting -> Stopping
@leemthompo leemthompo mentioned this pull request Jan 20, 2025
Merged
leemthompo pushed a commit to leemthompo/elasticsearch that referenced this pull request Jan 20, 2025
@hanjongho @leemthompo
Update security-basic-setup.asciidoc (elastic#117009)
d7d120b 
Fix Starting -> Stopping
This was referenced Jan 20, 2025
Merged
Merged
Merged
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.14
✅ 8.15
✅ 8.17
✅ 8.x

leemthompo pushed a commit to leemthompo/elasticsearch that referenced this pull request Jan 20, 2025
@hanjongho @leemthompo
Update security-basic-setup.asciidoc (elastic#117009)
b53b530 
Fix Starting -> Stopping
leemthompo pushed a commit to leemthompo/elasticsearch that referenced this pull request Jan 20, 2025
@hanjongho @leemthompo
Update security-basic-setup.asciidoc (elastic#117009)
9e8d875 
Fix Starting -> Stopping
elasticsearchmachine pushed a commit that referenced this pull request Jan 20, 2025
@leemthompo @hanjongho
Update security-basic-setup.asciidoc (#117009) (#120456)
a1769b7 
Fix Starting -> Stopping

Co-authored-by: Jongho Han <lgwl81@gmail.com>
elasticsearchmachine pushed a commit that referenced this pull request Jan 20, 2025
@leemthompo @hanjongho
Update security-basic-setup.asciidoc (#117009) (#120457)
9560e6b 
Fix Starting -> Stopping

Co-authored-by: Jongho Han <lgwl81@gmail.com>
elasticsearchmachine pushed a commit that referenced this pull request Jan 20, 2025
@leemthompo @hanjongho
Update security-basic-setup.asciidoc (#117009) (#120454)
488199a 
Fix Starting -> Stopping

Co-authored-by: Jongho Han <lgwl81@gmail.com>
elasticsearchmachine pushed a commit that referenced this pull request Jan 20, 2025
@leemthompo @hanjongho
Update security-basic-setup.asciidoc (#117009) (#120455)
157fe74 
Fix Starting -> Stopping

Co-authored-by: Jongho Han <lgwl81@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leemthompo leemthompo leemthompo approved these changes

Assignees

@leemthompo leemthompo

Labels

auto-backport Automatically create backport pull requests when merged >docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Docs Meta label for docs team v8.14.0 v8.15.0 v8.16.4 v8.17.0 v8.18.0 v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hanjongho @elasticsearchmachine @leemthompo @gbanasiak