[8.x] kNN vector rescoring for quantized vectors (#116663) #118418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 5996772) # Conflicts: # server/src/main/java/org/elasticsearch/search/vectors/KnnSearchBuilder.java # x-pack/plugin/rank-rrf/src/main/java/org/elasticsearch/xpack/rank/rrf/RRFRankBuilder.java
6 tasks
carlosdelest
added
the
auto-merge-without-approval
carlosdelest
commented
Dec 11, 2024
| @Override | ||
| public double doubleValue() throws IOException { | ||
| vectorOpsCount++; | ||
| return vectorSimilarityFunction.compare(target, vectorValues.vectorValue()); |
Member
Author
There was a problem hiding this comment.
@benwtrent , FYI - this is different than the original PR as Lucene 10 has a different interface for FloatVectorValues vector retrieval.
I believe we're covered by testing and the checks I've done, but flagging for additional 👀 on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation