Skip to content

ESQL: Disable tests planned incorrectly on pre-8.13 (failing BWC) (#118655) #118685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 16, 2024
Merged

ESQL: Disable tests planned incorrectly on pre-8.13 (failing BWC) (#118655) #118685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fd58564
ESQL: Disable grok.OverwriteName* on pre-8.13 BWC tests (#118655)
bpintea Dec 13, 2024
699bf8b
re-enabled disabled tests
bpintea Dec 13, 2024
2db8dee
Merge branch '8.x' into port/118655
bpintea Dec 13, 2024
160daf4
Merge remote-tracking branch 'upstream/8.x' into port/118655
bpintea Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,24 +425,9 @@ tests:
- class: org.elasticsearch.discovery.ec2.DiscoveryEc2AvailabilityZoneAttributeNoImdsIT
method: testAvailabilityZoneAttribute
issue: https://github.com/elastic/elasticsearch/issues/118564
- class: org.elasticsearch.xpack.esql.qa.mixed.MixedClusterEsqlSpecIT
method: test {grok.OverwriteName SYNC}
issue: https://github.com/elastic/elasticsearch/issues/118631
- class: org.elasticsearch.xpack.esql.qa.mixed.MixedClusterEsqlSpecIT
method: test {stats.ByStringAndLongWithAlias SYNC}
issue: https://github.com/elastic/elasticsearch/issues/118632
- class: org.elasticsearch.xpack.esql.qa.mixed.MixedClusterEsqlSpecIT
method: test {dissect.OverwriteNameWhere SYNC}
issue: https://github.com/elastic/elasticsearch/issues/118633
- class: org.elasticsearch.xpack.searchablesnapshots.RetrySearchIntegTests
method: testRetryPointInTime
issue: https://github.com/elastic/elasticsearch/issues/118514
- class: org.elasticsearch.xpack.esql.qa.mixed.MixedClusterEsqlSpecIT
method: test {grok.OverwriteNameWhere SYNC}
issue: https://github.com/elastic/elasticsearch/issues/118638
- class: org.elasticsearch.xpack.esql.qa.mixed.MixedClusterEsqlSpecIT
method: test {dissect.OverwriteName SYNC}
issue: https://github.com/elastic/elasticsearch/issues/118667
- class: org.elasticsearch.xpack.esql.qa.mixed.MixedClusterEsqlSpecIT
method: test {stats.ByDateAndKeywordAndIntWithAlias SYNC}
issue: https://github.com/elastic/elasticsearch/issues/118668
Expand Down
6 changes: 4 additions & 2 deletions x-pack/plugin/esql/qa/testFixtures/src/main/resources/dissect.csv-spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,8 @@ null | null | null
;


overwriteName
// the query is incorrectly physically plan (fails the verification) in pre-8.13.0 versions
overwriteName#[skip:-8.12.99]
from employees | sort emp_no asc | eval full_name = concat(first_name, " ", last_name) | dissect full_name "%{emp_no} %{b}" | keep full_name, emp_no, b | limit 3;

full_name:keyword | emp_no:keyword | b:keyword
Expand All @@ -244,7 +245,8 @@ emp_no:integer | first_name:keyword | rest:keyword
;


overwriteNameWhere
// the query is incorrectly physically plan (fails the verification) in pre-8.13.0 versions
overwriteNameWhere#[skip:-8.12.99]
from employees | sort emp_no asc | eval full_name = concat(first_name, " ", last_name) | dissect full_name "%{emp_no} %{b}" | where emp_no == "Bezalel" | keep full_name, emp_no, b | limit 3;

full_name:keyword | emp_no:keyword | b:keyword
Expand Down
6 changes: 4 additions & 2 deletions x-pack/plugin/esql/qa/testFixtures/src/main/resources/grok.csv-spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,8 @@ null | null | null
;


overwriteName
// the query is incorrectly physically plan (fails the verification) in pre-8.13.0 versions
overwriteName#[skip:-8.12.99]
from employees | sort emp_no asc | eval full_name = concat(first_name, " ", last_name) | grok full_name "%{WORD:emp_no} %{WORD:b}" | keep full_name, emp_no, b | limit 3;

full_name:keyword | emp_no:keyword | b:keyword
Expand All @@ -209,7 +210,8 @@ Parto Bamford | Parto | Bamford
;


overwriteNameWhere
// the query is incorrectly physically plan (fails the verification) in pre-8.13.0 versions
overwriteNameWhere#[skip:-8.12.99]
from employees | sort emp_no asc | eval full_name = concat(first_name, " ", last_name) | grok full_name "%{WORD:emp_no} %{WORD:b}" | where emp_no == "Bezalel" | keep full_name, emp_no, b | limit 3;

full_name:keyword | emp_no:keyword | b:keyword
Expand Down
3 changes: 2 additions & 1 deletion x-pack/plugin/esql/qa/testFixtures/src/main/resources/stats.csv-spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,7 +564,8 @@ c:long | gender:keyword | trunk_worked_seconds:long
0 | null | 200000000
;

byStringAndLongWithAlias
// the query is incorrectly physically plan (fails the verification) in pre-8.13.0 versions
byStringAndLongWithAlias#[skip:-8.12.99]
FROM employees
| EVAL trunk_worked_seconds = avg_worked_seconds / 100000000 * 100000000
| RENAME gender as g, trunk_worked_seconds as tws
Expand Down