Skip to content

[8.x] Fix off-by-one error in RecoverySourcePruneMergePolicyTests#testPruneSome #118973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 18, 2024
Merged

[8.x] Fix off-by-one error in RecoverySourcePruneMergePolicyTests#testPruneSome #118973

merged 2 commits into from
Dec 18, 2024

Conversation

@arteam
Copy link
Contributor

@arteam arteam commented Dec 18, 2024

Backports #118944 to 8.x

The extra_source_size field is set to a value between 10 and 10000 inclusive, so the assertion should be greaterThanOrEqualTo(10) rather than greaterThan(10).

See #114618
Resolve #118728

@arteam arteam added >test Issues or PRs that are addressing/adding tests backport auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) labels Dec 18, 2024
@elasticsearchmachine elasticsearchmachine merged commit fe0f14f into 8.x Dec 18, 2024
16 checks passed
@elasticsearchmachine elasticsearchmachine deleted the backport-118944 branch December 18, 2024 16:16
martijnvg added a commit to martijnvg/elasticsearch that referenced this pull request Dec 19, 2024
@martijnvg
Unmute fixed tests via elastic#119089 and elastic#118973
89422c1
martijnvg added a commit that referenced this pull request Dec 19, 2024
@martijnvg
Unmute fixed tests via #119089 and #118973 (#119109)
92bc20a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport >test Issues or PRs that are addressing/adding tests v8.18.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arteam @elasticsearchmachine