Skip to content

[Failure store] Only add failure indices when failure store flag is on. #119934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 11, 2025
Merged

[Failure store] Only add failure indices when failure store flag is on. #119934

merged 6 commits into from
Jan 11, 2025

Conversation

gmarouli
Copy link
Contributor

We use the feature flag to determine if the failure indices need to be added to the cluster state and tested.

Fixes: #119908
Fixes: #119909

@gmarouli gmarouli added >test Issues or PRs that are addressing/adding tests :Data Management/Data streams Data streams and their lifecycles labels Jan 10, 2025
@gmarouli gmarouli requested a review from jbaiera January 10, 2025 11:09
@elasticsearchmachine elasticsearchmachine added Team:Data Management Meta label for data/management team v9.0.0 labels Jan 10, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@gmarouli gmarouli mentioned this pull request Jan 10, 2025
Closed
@jbaiera
Copy link
Member

jbaiera commented Jan 10, 2025

@elasticmachine run elasticsearch-ci/part-2

jbaiera
jbaiera approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@jbaiera jbaiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@jbaiera jbaiera mentioned this pull request Jan 11, 2025
Closed
@jbaiera jbaiera linked an issue Jan 11, 2025 that may be closed by this pull request
[CI] IndicesAndAliasesResolverTests testDataStreamNotAuthorizedWhenBackingIndicesAreAuthorizedViaNameAndRequestThatExcludesDataStreams failing #120015
Closed
@jbaiera jbaiera merged commit eefee72 into elastic:main Jan 11, 2025
16 checks passed
@jbaiera jbaiera mentioned this pull request Jan 11, 2025
Merged
@jbaiera
Copy link
Member

jbaiera commented Jan 11, 2025

Most of this PR has already been backported to 8.x via #119832, but one further change is being backported from the commit 2409d02 in #120017

@gmarouli
Copy link
Contributor Author

@jbaiera thank you for following up on it ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbaiera jbaiera jbaiera approved these changes

Assignees

No one assigned

Labels

:Data Management/Data streams Data streams and their lifecycles Team:Data Management Meta label for data/management team >test Issues or PRs that are addressing/adding tests v8.18.0 v9.0.0

Projects

None yet

Milestone

No milestone

3 participants

@gmarouli @elasticsearchmachine @jbaiera