(WIP) Plug in balancer round summary stats #120135
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DesiredBalanceReconciler applies desired balance to the routing table cluster metadata. This patch extract logic from the reconciler that pushes updates to the desired balance metrics. This removes extra parameters passed into the DesiredBalanceReconciler, and enables expanding the metrics that are collected without passing more objects into the reconciler class.
Lays out the balancer summary information that we want to collect and eventually report. Only the class scaffolding, still needs implementation.
DiannaHohensee
added
the
Team:Distributed Coordination
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Publishing a WIP patch to show where #120085 and #119916 are heading (apologies for the mess, pushing quickly to provide context). The culmination part I'm working on that's missing from those two patches is primarily seen in the
DesiredBalanceShardsAllocator#reconcilemethod: I'm figuring out where to collect the new stats from so that they can be reported. New stats that are notably outside the Reconciler's purview are startTime, endTime, pre-reconciliation node weights, and the reason the balancing round began.Relates ES-10341