Node deprecation warning for indexes and component templates with sou… #120387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rce mode in mapping
kkrik-es
added
>non-issue
auto-backport
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
martijnvg
reviewed
Jan 20, 2025
Member
martijnvg
left a comment
martijnvg
left a comment
There was a problem hiding this comment.
Looks good! I don't think we need to do a deprecation for _source.mode for indices.
| List<String> indexes = new ArrayList<>(); | ||
| for (String indexName : clusterState.metadata().getIndices().keySet()) { | ||
| IndexMetadata indexMetadata = clusterState.metadata().getIndices().get(indexName); | ||
| if (SourceFieldMapper.onOrAfterDeprecateModeVersion(indexMetadata.getCreationVersion())) { |
Member
There was a problem hiding this comment.
I don't think we need to emit warnings for _source.mode mapping attribute usage in indices, because these are not actionable. The source mode can't be changed after the index has been created. This is different for templates.
Member
There was a problem hiding this comment.
Note that create index api will return emit a deprecation warning if _source.mode mapping attribute is used. This is visible as response header and in the deprecation log file.
...gin/deprecation/src/main/java/org/elasticsearch/xpack/deprecation/NodeDeprecationChecks.java
Outdated
Show resolved
Hide resolved
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
kkrik-es
added a commit
to kkrik-es/elasticsearch
that referenced
this pull request
Jan 21, 2025
elastic#120387) * Node deprecation warning for indexes and component templates with source mode in mapping * remove index warnings * restrict to component templates * refine (cherry picked from commit 110b206) # Conflicts: # x-pack/plugin/deprecation/src/main/java/org/elasticsearch/xpack/deprecation/IndexDeprecationChecks.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 21, 2025
…th sou… (#120387) (#120493) * Node deprecation warning for indexes and component templates with sou… (#120387) * Node deprecation warning for indexes and component templates with source mode in mapping * remove index warnings * restrict to component templates * refine (cherry picked from commit 110b206) # Conflicts: # x-pack/plugin/deprecation/src/main/java/org/elasticsearch/xpack/deprecation/IndexDeprecationChecks.java * [CI] Auto commit changes from spotless * fix compilation error --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #119993