Remove IndexNameExpressionResolver from base transport classes that don't use it #120531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
Team:Core/Infra
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
thecoop
commented
Jan 21, 2025
| protected final ThreadPool threadPool; | ||
| protected final TransportService transportService; | ||
| protected final ClusterService clusterService; | ||
| protected final IndexNameExpressionResolver indexNameExpressionResolver; |
DaveCTurner
approved these changes
Jan 21, 2025
thecoop
added
auto-backport
elasticsearchmachine
added
the
serverless-linked
💔 Backport failed
You can use sqren/backport to manually backport by running |
thecoop
added a commit
to thecoop/elasticsearch
that referenced
this pull request
Jan 22, 2025
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Feb 24, 2025
Follow-up to elastic#120531 to remove all the now-redundant constructor parameters.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 24, 2025
Follow-up to #120531 to remove all the now-redundant constructor parameters.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Feb 24, 2025
Follow-up to elastic#120531 to remove all the now-redundant constructor parameters.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Feb 24, 2025
Follow-up to elastic#120531 to remove all the now-redundant constructor parameters. Backport of elastic#123258 to 8.x
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 24, 2025
) Follow-up to #120531 to remove all the now-redundant constructor parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IndexNameExpressionResolveris needed byTransportMasterNodeAction, even though it doesn't use it. This removesIndexNameExpressionResolverfrom that base class, moving the field into classes that actually use it.Note that the majority of these changes were automated remove-parameter refactorings.
There are many classes that still have
IndexNameExpressionResolverin their injection constructor that doesn't go anywhere - these can be removed as part of this PR (once the concept is approved), or later over time.