ESQL: Make it a little easier to test LOOKUP #120540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the internals of LOOKUP so they don't rely directly on `SearchContext`, instead relying on their own `LookupShardContext` which is easy to build from a `SearchContext`. The advantage is that it's easier to build it *without* a `SearchContext` which makes unit testing a ton easier.
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
nik9000
commented
Jan 21, 2025
| EsPhysicalOperationProviders.ShardContext context, | ||
| SearchExecutionContext executionContext, | ||
| Releasable release | ||
| ) { |
There was a problem hiding this comment.
It's not 100% clear to me that it wouldn't be better to make this an interface, but I figure I can get that in when I make the test. I just wanted to get this change in to start talking about how the test would have to change things.
|
Thanks @costin ! |
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Jan 21, 2025
* ESQL: Make it a little easier to test LOOKUP This changes the internals of LOOKUP so they don't rely directly on `SearchContext`, instead relying on their own `LookupShardContext` which is easy to build from a `SearchContext`. The advantage is that it's easier to build it *without* a `SearchContext` which makes unit testing a ton easier. * JAVADOC
|
Backport #120555 |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 21, 2025
* ESQL: Make it a little easier to test LOOKUP This changes the internals of LOOKUP so they don't rely directly on `SearchContext`, instead relying on their own `LookupShardContext` which is easy to build from a `SearchContext`. The advantage is that it's easier to build it *without* a `SearchContext` which makes unit testing a ton easier. * JAVADOC
| /** | ||
| * Create a {@link LookupShardContext} for a locally allocated {@link ShardId}. | ||
| */ | ||
| public interface CreateShardContext { |
There was a problem hiding this comment.
NIT: Should this be called LookupShardContextFactory to avoid confusion with a method name?
There was a problem hiding this comment.
Yeah, that probably would have been more clear. I can rename this in the followup PR you just reviewed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the internals of LOOKUP so they don't rely directly on
SearchContext, instead relying on their ownLookupShardContextwhich is easy to build from aSearchContext. The advantage is that it's easier to build it without aSearchContextwhich makes unit testing a ton easier.