ESQL: Fix lookup test result ordering #120622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, re-order the test cases to remain consistent: put all the multi-match tests next to the multi-value and null match tests.
alex-spies
added
>test
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
alex-spies
commented
Jan 22, 2025
| ; | ||
|
|
||
| repeatedIndexOnFrom | ||
| required_capability: join_lookup_v11 |
There was a problem hiding this comment.
Just moved out of the multi-match tests.
| ; | ||
|
|
||
| ########################################################################### | ||
| # null and multi-value behavior with languages_lookup_non_unique_key index |
There was a problem hiding this comment.
Entire section moved up to be next to the multi-match tests.
Comment on lines
+200
to
+201
| nonUniqueRightKeyOnTheCoordinatorCorrectOrdering | ||
| // Same as above, but don't ignore the order completely. At least the emp_no col must remain correctly ordered. |
There was a problem hiding this comment.
This one is new, because above we have to ignore the ordering and thus don't test that the left key ordering remains stable. This test does.
idegtiarenko
approved these changes
Jan 22, 2025
ivancea
approved these changes
Jan 22, 2025
alex-spies
added
the
auto-merge-without-approval
alex-spies
commented
Jan 22, 2025
|
|
||
| mvJoinKeyOnFrom | ||
| required_capability: join_lookup_v11 | ||
| required_capability: join_lookup_skip_mv |
There was a problem hiding this comment.
@ivancea , I thought I'll fix this one while I'm at it.
💔 Backport failed
You can use sqren/backport to manually backport by running |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
alex-spies
added a commit
to alex-spies/elasticsearch
that referenced
this pull request
Jan 23, 2025
Fix elastic#120600 Fix elastic#120601 Fix elastic#120602 Fix elastic#120603 Fix elastic#120658 Fix elastic#120659 While I was at it, I moved the LOOKUP JOINs test cases with multiple right keys next to the test cases with multivalues and nulls in keys to be consistent and make stuff more easy to find. (cherry picked from commit b985b3e) # Conflicts: # muted-tests.yml
alex-spies
added a commit
that referenced
this pull request
Jan 24, 2025
Fix #120600 Fix #120601 Fix #120602 Fix #120603 Fix #120658 Fix #120659 While I was at it, I moved the LOOKUP JOINs test cases with multiple right keys next to the test cases with multivalues and nulls in keys to be consistent and make stuff more easy to find. (cherry picked from commit b985b3e) # Conflicts: # muted-tests.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #120600
Fix #120601
Fix #120602
Fix #120603
Fix #120658
Fix #120659
While I was at it, I moved the LOOKUP JOINs test cases with multiple right keys next to the test cases with multivalues and nulls in keys to be consistent and make stuff more easy to find.