Improve logging of put-mapping failures #121372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No sense in converting to a list just to convert to a string, we may as well convert directly to a string. Also removes the unnecessary extra `[]` wrapper.
DaveCTurner
added
:Distributed Indexing/CRUD
elasticsearchmachine
added
the
Team:Distributed Indexing
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
DaveCTurner
commented
Jan 31, 2025
| performMappingUpdate(concreteIndices, request, listener, metadataMappingService, false); | ||
| } catch (IndexNotFoundException ex) { | ||
| logger.debug(() -> "failed to put mappings on indices [" + Arrays.asList(request.indices() + "]"), ex); | ||
| logger.debug(() -> "failed to put mappings on indices " + Arrays.toString(request.indices()), ex); |
There was a problem hiding this comment.
This one was actually just plain wrong: note that the arg to Arrays.asList was request.indices() + "]" so this was already converting the array to a string (badly), then back to an array, then to a list, and then to a string again. It's also not possible to hit this AFAICT because if the index doesn't exist we would already have thrown an INFE in checkBlock, which should be using the same ClusterState as the one we have here. At least I couldn't hit it in a test.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jan 31, 2025
No sense in converting to a list just to convert to a string, we may as well convert directly to a string. Also removes the unnecessary extra `[]` wrapper.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jan 31, 2025
No sense in converting to a list just to convert to a string, we may as well convert directly to a string. Also removes the unnecessary extra `[]` wrapper.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jan 31, 2025
No sense in converting to a list just to convert to a string, we may as well convert directly to a string. Also removes the unnecessary extra `[]` wrapper.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 31, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 31, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 6, 2025
* Improve logging of put-mapping failures (#121372) No sense in converting to a list just to convert to a string, we may as well convert directly to a string. Also removes the unnecessary extra `[]` wrapper. * CI poke * CI poke
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No sense in converting to a list just to convert to a string, we may as
well convert directly to a string. Also removes the unnecessary extra
[]wrapper.