Skip to content

Conversation

@smalyshev
Copy link
Contributor

Clean up duplication, move stop tests to separate test

Clean up duplication, move stop tests to separate test
@smalyshev smalyshev added v8.19.0 >test Issues or PRs that are addressing/adding tests :Analytics/ES|QL AKA ESQL >refactoring labels Feb 3, 2025
Copy link
Contributor

@quux00 quux00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for doing this refactoring.

@smalyshev smalyshev marked this pull request as ready for review February 3, 2025 20:32
@smalyshev smalyshev merged commit dbf1539 into elastic:main Feb 3, 2025
17 checks passed
@smalyshev
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.x

Questions ?

Please refer to the Backport tool documentation

elasticsearchmachine pushed a commit that referenced this pull request Feb 3, 2025
* Refactor CCS tests (#121547)

* Refactor CCS tests

Clean up duplication, move stop tests to separate test

(cherry picked from commit dbf1539)

# Conflicts:
#	muted-tests.yml
#	x-pack/plugin/esql/src/internalClusterTest/java/org/elasticsearch/xpack/esql/action/CrossClusterAsyncQueryIT.java
#	x-pack/plugin/esql/src/internalClusterTest/java/org/elasticsearch/xpack/esql/action/CrossClusterQueryIT.java
#	x-pack/plugin/esql/src/internalClusterTest/java/org/elasticsearch/xpack/esql/action/CrossClusterQueryUnavailableRemotesIT.java

* Unmute test on 8.x too

* fix test
@smalyshev smalyshev deleted the split-stop-tests branch February 3, 2025 22:59
fzowl pushed a commit to voyage-ai/elasticsearch that referenced this pull request Feb 4, 2025
* Refactor CCS tests

Clean up duplication, move stop tests to separate test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL >refactoring >test Issues or PRs that are addressing/adding tests v8.19.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants