Sort groups of instrumented methods #121616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instrumented methods in EntitlementChecker are loosely grouped by the associated entitlement. This commit sorts the methods within groups to allow more clear placement of additional instrumented methods.
rjernst
added
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
I'd get rid of the delineated sections and sort them all. That way, the sorting could (at least in principle) be maintained by tooling. |
This will at least get us started so we can implement file checks in parallel. We can separately discuss if we want to sort the entire checkers. |
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Feb 4, 2025
Instrumented methods in EntitlementChecker are loosely grouped by the associated entitlement. This commit sorts the methods within groups to allow more clear placement of additional instrumented methods.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Feb 4, 2025
Instrumented methods in EntitlementChecker are loosely grouped by the associated entitlement. This commit sorts the methods within groups to allow more clear placement of additional instrumented methods.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Feb 4, 2025
Instrumented methods in EntitlementChecker are loosely grouped by the associated entitlement. This commit sorts the methods within groups to allow more clear placement of additional instrumented methods.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 5, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 5, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instrumented methods in EntitlementChecker are loosely grouped by the associated entitlement. This commit sorts the methods within groups to allow more clear placement of additional instrumented methods.