[ML] Parse mid-stream errors from OpenAI and EIS #121806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we are already parsing events, we can receive errors as the next event. OpenAI formats these as: ``` event: error data: <payload> ``` Elastic formats these as: ``` data: <payload> ``` Unified will consolidate them into the new error structure.
prwhelan
added
>bug
:ml
|
Hi @prwhelan, I've created a changelog YAML for you. |
|
Pinging @elastic/ml-core (Team:ML) |
| } | ||
|
|
||
| private static Exception buildMidStreamError(Request request, String message, Exception e) { | ||
| var restStatus = RestStatus.OK; |
There was a problem hiding this comment.
Should this be the same as the EIS one?
| var results = new ArrayDeque<StreamingUnifiedChatCompletionResults.ChatCompletionChunk>(item.size()); | ||
| for (var event : item) { | ||
| if (ServerSentEventField.EVENT == event.name() && "error".equals(event.value())) { | ||
| previousEventWasNotError = false; |
There was a problem hiding this comment.
nit: This might be a bit easier to read using the positive form previousEventWasAnError = true.
Then in the check below we could do:
if (previousEventWasAnError) {
throw errorParser.apply(event.value(), null);
}
try {
} catch () {
}
jonathan-buttner
approved these changes
Feb 6, 2025
prwhelan
added a commit
to prwhelan/elasticsearch
that referenced
this pull request
Feb 6, 2025
When we are already parsing events, we can receive errors as the next event. OpenAI formats these as: ``` event: error data: <payload> ``` Elastic formats these as: ``` data: <payload> ``` Unified will consolidate them into the new error structure.
prwhelan
added a commit
to prwhelan/elasticsearch
that referenced
this pull request
Feb 6, 2025
When we are already parsing events, we can receive errors as the next event. OpenAI formats these as: ``` event: error data: <payload> ``` Elastic formats these as: ``` data: <payload> ``` Unified will consolidate them into the new error structure.
prwhelan
added a commit
to prwhelan/elasticsearch
that referenced
this pull request
Feb 6, 2025
When we are already parsing events, we can receive errors as the next event. OpenAI formats these as: ``` event: error data: <payload> ``` Elastic formats these as: ``` data: <payload> ``` Unified will consolidate them into the new error structure.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 6, 2025
When we are already parsing events, we can receive errors as the next event. OpenAI formats these as: ``` event: error data: <payload> ``` Elastic formats these as: ``` data: <payload> ``` Unified will consolidate them into the new error structure.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 7, 2025
When we are already parsing events, we can receive errors as the next event. OpenAI formats these as: ``` event: error data: <payload> ``` Elastic formats these as: ``` data: <payload> ``` Unified will consolidate them into the new error structure.
prwhelan
added a commit
that referenced
this pull request
Feb 7, 2025
When we are already parsing events, we can receive errors as the next event. OpenAI formats these as: ``` event: error data: <payload> ``` Elastic formats these as: ``` data: <payload> ``` Unified will consolidate them into the new error structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we are already parsing events, we can receive errors as the next event.
OpenAI formats these as:
Elastic formats these as:
Unified will consolidate them into the new error structure.