Add 9.0 patch transport version constants #121985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transport version changes must be unique per branch. Some transport version changes meant for 9.0 are missing unique backport constants. This commit adds constants and adjusts the transport logic to use the new constants.
rjernst
added
>non-issue
:Core/Infra/Transport API
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
mark-vieira
reviewed
Feb 6, 2025
| public static final TransportVersion ML_INFERENCE_IBM_WATSONX_RERANK_ADDED = def(8_840_0_00); | ||
| public static final TransportVersion COHERE_BIT_EMBEDDING_TYPE_SUPPORT_ADDED_BACKPORT_8_X = def(8_840_0_01); | ||
| public static final TransportVersion ELASTICSEARCH_9_0 = def(9_000_0_00); | ||
| public static final TransportVersion REMOVE_SNAPSHOT_FAILURES_90 = def(9_001_0_01); |
There was a problem hiding this comment.
Is there a reason why this one is a patch off of 9_001 but the others are patches from 9_000?
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Feb 6, 2025
Transport version changes must be unique per branch. Some transport version changes meant for 9.0 are missing unique backport constants. This is a backport of elastic#121985, adding unique transport version patch numbers for each change intended for 9.0.
|
Note: see the 9.0 branch change here: #121986 |
mark-vieira
approved these changes
Feb 6, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 7, 2025
* Add 9.0 patch transport version constants #121985 Transport version changes must be unique per branch. Some transport version changes meant for 9.0 are missing unique backport constants. This is a backport of #121985, adding unique transport version patch numbers for each change intended for 9.0. * match constant naming in main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transport version changes must be unique per branch. Some transport version changes meant for 9.0 are missing unique backport constants. This commit adds constants and adjusts the transport logic to use the new constants.