Fix testValidFromPattern #121996
Merged
Fix testValidFromPattern #121996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idegtiarenko
added
>test
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
alex-spies
approved these changes
Feb 7, 2025
luigidellaquila
approved these changes
Feb 7, 2025
💔 Backport failed
You can use sqren/backport to manually backport by running |
This was referenced Feb 7, 2025
idegtiarenko
added a commit
to idegtiarenko/elasticsearch
that referenced
this pull request
Feb 7, 2025
(cherry picked from commit c92b7b5)
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 7, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #120355 now it is possible to generate patterns with remote and data math that are quoted as following:
"remote":<index-{now/M{yyyy.MM.dd|+16:00}}>.|require indexPattern to be quoted. Unfortunately, the branch that is doing so was erroneously detecting quotes on clasterPattern only, not on entire identifier.elasticsearch/x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/IdentifierGenerator.java
Lines 87 to 89 in 24bc9fa
This change fixes that.
Closes: #121990
Closes: #121968