Skip SecurityManager policy parsing and validation for JDK 24+ #122233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldematte
added
>non-issue
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
mark-vieira
approved these changes
Feb 11, 2025
ldematte
added a commit
to ldematte/elasticsearch
that referenced
this pull request
Feb 12, 2025
ldematte
added a commit
to ldematte/elasticsearch
that referenced
this pull request
Feb 12, 2025
ldematte
added a commit
to ldematte/elasticsearch
that referenced
this pull request
Feb 12, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 12, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 12, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During plugin install, we validate the plugin's policy file against a set of allowed/disallowed permissions. However, methods for anything related to SecurityManager (including policy parsing) have been removed from JDK 24+.
We will eventually completely remove this code once Entitlements (SecurityManager replacement) is complete; this PR provisionally disable policy parsing and validation if the SecurityManager is not available (has been removed).
closes #121989