-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[Test] Fix QueryableReservedRolesIT testQueryDeleteOrUpdateReservedRoles #122803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
slobodanadamovic
merged 1 commit into
elastic:main
from
slobodanadamovic:sa-fix-testQueryDeleteOrUpdateReservedRoles
Feb 17, 2025
Merged
[Test] Fix QueryableReservedRolesIT testQueryDeleteOrUpdateReservedRoles #122803
slobodanadamovic
merged 1 commit into
elastic:main
from
slobodanadamovic:sa-fix-testQueryDeleteOrUpdateReservedRoles
Feb 17, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-security (Team:Security) |
n1v0lg
approved these changes
Feb 17, 2025
slobodanadamovic
added a commit
to slobodanadamovic/elasticsearch
that referenced
this pull request
Feb 17, 2025
…les (elastic#122803) Adds missing `assertBusy` in `testQueryDeleteOrUpdateReservedRoles`. We wait for security migration to finish before test execution, but this is not enough to guarantee that built-in roles are synchronized into the `.security` index. In many cases, the roles have already been synchronized before the query gets executed, but in rare cases the cluster is a bit slower and the assertion fails because the built-in roles have not been indexed yet. Resolves elastic#120401
slobodanadamovic
added a commit
to slobodanadamovic/elasticsearch
that referenced
this pull request
Feb 17, 2025
…les (elastic#122803) Adds missing `assertBusy` in `testQueryDeleteOrUpdateReservedRoles`. We wait for security migration to finish before test execution, but this is not enough to guarantee that built-in roles are synchronized into the `.security` index. In many cases, the roles have already been synchronized before the query gets executed, but in rare cases the cluster is a bit slower and the assertion fails because the built-in roles have not been indexed yet. Resolves elastic#120401
slobodanadamovic
added a commit
to slobodanadamovic/elasticsearch
that referenced
this pull request
Feb 17, 2025
…les (elastic#122803) Adds missing `assertBusy` in `testQueryDeleteOrUpdateReservedRoles`. We wait for security migration to finish before test execution, but this is not enough to guarantee that built-in roles are synchronized into the `.security` index. In many cases, the roles have already been synchronized before the query gets executed, but in rare cases the cluster is a bit slower and the assertion fails because the built-in roles have not been indexed yet. Resolves elastic#120401
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 19, 2025
…les (#122803) (#122808) Adds missing `assertBusy` in `testQueryDeleteOrUpdateReservedRoles`. We wait for security migration to finish before test execution, but this is not enough to guarantee that built-in roles are synchronized into the `.security` index. In many cases, the roles have already been synchronized before the query gets executed, but in rare cases the cluster is a bit slower and the assertion fails because the built-in roles have not been indexed yet. Resolves #120401
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 20, 2025
…les (#122803) (#122807) Adds missing `assertBusy` in `testQueryDeleteOrUpdateReservedRoles`. We wait for security migration to finish before test execution, but this is not enough to guarantee that built-in roles are synchronized into the `.security` index. In many cases, the roles have already been synchronized before the query gets executed, but in rare cases the cluster is a bit slower and the assertion fails because the built-in roles have not been indexed yet. Resolves #120401
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 20, 2025
…les (#122803) (#122806) Adds missing `assertBusy` in `testQueryDeleteOrUpdateReservedRoles`. We wait for security migration to finish before test execution, but this is not enough to guarantee that built-in roles are synchronized into the `.security` index. In many cases, the roles have already been synchronized before the query gets executed, but in rare cases the cluster is a bit slower and the assertion fails because the built-in roles have not been indexed yet. Resolves #120401
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
:Security/Security
Security issues without another label
Team:Security
Meta label for security team
>test
Issues or PRs that are addressing/adding tests
v8.18.1
v8.19.0
v9.0.1
v9.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing
assertBusyintestQueryDeleteOrUpdateReservedRoles. We wait for security migration to finish before test execution, but this is not enough to guarantee that built-in roles are synchronized into the.securityindex. In many cases, the roles have already been synchronized before the query gets executed, but in rare cases the cluster is a bit slower (always on Windows) and the assertion fails because the built-in roles have not been indexed yet.Resolves #120401