Skip to content

Conversation

@slobodanadamovic
Copy link
Contributor

Adds missing assertBusy in testQueryDeleteOrUpdateReservedRoles. We wait for security migration to finish before test execution, but this is not enough to guarantee that built-in roles are synchronized into the .security index. In many cases, the roles have already been synchronized before the query gets executed, but in rare cases the cluster is a bit slower (always on Windows) and the assertion fails because the built-in roles have not been indexed yet.

Resolves #120401

@slobodanadamovic slobodanadamovic added >test Issues or PRs that are addressing/adding tests :Security/Security Security issues without another label Team:Security Meta label for security team v8.18.1 v8.19.0 v9.0.1 v9.1.0 labels Feb 17, 2025
@slobodanadamovic slobodanadamovic self-assigned this Feb 17, 2025
@slobodanadamovic slobodanadamovic requested a review from a team February 17, 2025 20:03
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

@slobodanadamovic slobodanadamovic added the auto-backport Automatically create backport pull requests when merged label Feb 17, 2025
@slobodanadamovic slobodanadamovic merged commit 2f4abbf into elastic:main Feb 17, 2025
22 checks passed
slobodanadamovic added a commit to slobodanadamovic/elasticsearch that referenced this pull request Feb 17, 2025
…les (elastic#122803)

Adds missing `assertBusy` in `testQueryDeleteOrUpdateReservedRoles`. 
We wait for security migration to finish before test execution, but this is not 
enough to guarantee that built-in roles are synchronized into the `.security` 
index. In many cases, the roles have already been synchronized before the 
query gets executed, but in rare cases the cluster is a bit slower and the 
assertion fails because the built-in roles have not been indexed yet.

Resolves elastic#120401
slobodanadamovic added a commit to slobodanadamovic/elasticsearch that referenced this pull request Feb 17, 2025
…les (elastic#122803)

Adds missing `assertBusy` in `testQueryDeleteOrUpdateReservedRoles`. 
We wait for security migration to finish before test execution, but this is not 
enough to guarantee that built-in roles are synchronized into the `.security` 
index. In many cases, the roles have already been synchronized before the 
query gets executed, but in rare cases the cluster is a bit slower and the 
assertion fails because the built-in roles have not been indexed yet.

Resolves elastic#120401
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.18
8.x
9.0

slobodanadamovic added a commit to slobodanadamovic/elasticsearch that referenced this pull request Feb 17, 2025
…les (elastic#122803)

Adds missing `assertBusy` in `testQueryDeleteOrUpdateReservedRoles`. 
We wait for security migration to finish before test execution, but this is not 
enough to guarantee that built-in roles are synchronized into the `.security` 
index. In many cases, the roles have already been synchronized before the 
query gets executed, but in rare cases the cluster is a bit slower and the 
assertion fails because the built-in roles have not been indexed yet.

Resolves elastic#120401
elasticsearchmachine pushed a commit that referenced this pull request Feb 19, 2025
…les (#122803) (#122808)

Adds missing `assertBusy` in `testQueryDeleteOrUpdateReservedRoles`. 
We wait for security migration to finish before test execution, but this is not 
enough to guarantee that built-in roles are synchronized into the `.security` 
index. In many cases, the roles have already been synchronized before the 
query gets executed, but in rare cases the cluster is a bit slower and the 
assertion fails because the built-in roles have not been indexed yet.

Resolves #120401
elasticsearchmachine pushed a commit that referenced this pull request Feb 20, 2025
…les (#122803) (#122807)

Adds missing `assertBusy` in `testQueryDeleteOrUpdateReservedRoles`. 
We wait for security migration to finish before test execution, but this is not 
enough to guarantee that built-in roles are synchronized into the `.security` 
index. In many cases, the roles have already been synchronized before the 
query gets executed, but in rare cases the cluster is a bit slower and the 
assertion fails because the built-in roles have not been indexed yet.

Resolves #120401
elasticsearchmachine pushed a commit that referenced this pull request Feb 20, 2025
…les (#122803) (#122806)

Adds missing `assertBusy` in `testQueryDeleteOrUpdateReservedRoles`. 
We wait for security migration to finish before test execution, but this is not 
enough to guarantee that built-in roles are synchronized into the `.security` 
index. In many cases, the roles have already been synchronized before the 
query gets executed, but in rare cases the cluster is a bit slower and the 
assertion fails because the built-in roles have not been indexed yet.

Resolves #120401
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged :Security/Security Security issues without another label Team:Security Meta label for security team >test Issues or PRs that are addressing/adding tests v8.18.1 v8.19.0 v9.0.1 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] QueryableReservedRolesIT testQueryDeleteOrUpdateReservedRoles failing

3 participants