ES|QL: Fix query builder rewriting when using lookup join #122833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
needs:triage
ioanatia
added
Team:Search
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
alex-spies
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
Thank you @ioanatia , LGTM! The added tests alone are super useful.
| } | ||
|
|
||
| public Set<String> indexNames(LogicalPlan plan) { | ||
| Holder<Set<String>> indexNames = new Holder<>(); |
There was a problem hiding this comment.
Yes, so because indexNames here did not include the name of the index that actually had the semantic_text field, the query builder rewriter does not rewrite the match query to the underlying semantic query.
This was referenced Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
more details in #122832
This is a fix for 8.18, it's not a bug that's present in 8.x or main.
I will add the tests we add here on main and 8.x.
Also separately figure out how we can bubble up the
IllegalArgumentExceptionthat's actually thrown during query rewrite at the shard level.