Fix JvmOptionsParserTests for Java 24 #123013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prdoyle
approved these changes
Feb 20, 2025
| @BeforeClass | ||
| public static void beforeClass() throws IOException { | ||
| Files.createDirectories(ENTITLEMENTS_LIB_DIR); | ||
| Files.createTempFile(ENTITLEMENTS_LIB_DIR, "mock-entitlements-bridge", ".jar"); |
There was a problem hiding this comment.
Why does this need the file? The directory is not enough?
There was a problem hiding this comment.
(I'm asking because I'm a bit surprised that it needs the file, but doesn't care about the file's name.)
There was a problem hiding this comment.
:D funny you asked, you probably removed that difficult phase of the project :)
The name of the jar itself is difficult to predict (with version, snapshot, etc), so the code there test we have exactly one jar in that directory, the name can be anything.
There was a problem hiding this comment.
Of course I remember that. I was just testing whether you knew. 😅
This was referenced Feb 21, 2025
afoucret
pushed a commit
to afoucret/elasticsearch
that referenced
this pull request
Feb 21, 2025
rjernst
pushed a commit
to rjernst/elasticsearch
that referenced
this pull request
Feb 25, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 26, 2025
rjernst
pushed a commit
to rjernst/elasticsearch
that referenced
this pull request
Feb 26, 2025
rjernst
pushed a commit
to rjernst/elasticsearch
that referenced
this pull request
Feb 26, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 26, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create "fake" test entitlement libs dir and jar to pass validation