Skip to content

Don't enable docvalues skippers by default for the time being. #124787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 13, 2025
Merged

Don't enable docvalues skippers by default for the time being. #124787

merged 2 commits into from
Mar 13, 2025

Conversation

@martijnvg
Copy link
Member

@martijnvg martijnvg commented Mar 13, 2025 •
edited
Loading

By change index.mapping.use_doc_values_skipper setting's default to false.

@martijnvg
Don't enable docvalues by default for the time being.
1e29309 
By change index.mapping.use_doc_values_skipper setting's default to false.
@martijnvg martijnvg added >non-issue :StorageEngine/Mapping The storage related side of mappings labels Mar 13, 2025
@martijnvg
Copy link
Member Author

martijnvg commented Mar 13, 2025 •
edited
Loading

Somehow setting use_doc_values_skipper track param in rally doesn't take effect: elastic/rally-tracks#749
Let's just change index.mapping.use_doc_values_skipper setting's default to false.
Not that this setting only exists in main branch.

@martijnvg martijnvg marked this pull request as ready for review March 13, 2025 17:34
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@martijnvg martijnvg enabled auto-merge (squash) March 13, 2025 17:40
@martijnvg
Copy link
Member Author

It looks like part of experimentally enabling doc values skippers did get merged into 9.0 branch: #120741
This why just 9.0 bwc CI failed. When #124803 is merged, then this PR's 9.0 CI job should succeed.

@martijnvg martijnvg changed the title Don't enable docvalues by default for the time being. Don't enable docvalues skippers by default for the time being. Mar 13, 2025
@martijnvg
Copy link
Member Author

@elasticmachine update branch

@martijnvg martijnvg merged commit 13bbd4b into elastic:main Mar 13, 2025
16 of 17 checks passed
@martijnvg martijnvg mentioned this pull request Mar 14, 2025
Closed
@kkrik-es kkrik-es mentioned this pull request Mar 14, 2025
Merged
elasticsearchmachine pushed a commit that referenced this pull request Mar 14, 2025
@kkrik-es
Unmute LogsdbIndexingRollingUpgradeIT tests (#124851)
7b30cd2 
These test failed briefly because
#124803 was merged and
#124787 wasn't.

Fixes #124830 Fixes #124831 Fixes #124833
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dnhatn dnhatn dnhatn approved these changes

@jordan-powers jordan-powers jordan-powers approved these changes

@kkrik-es kkrik-es kkrik-es approved these changes

Assignees

No one assigned

Labels

:StorageEngine/Mapping The storage related side of mappings Team:StorageEngine v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@martijnvg @elasticsearchmachine @dnhatn @jordan-powers @kkrik-es @elasticmachine