Remove TableInfo #126090
Merged
Remove TableInfo #126090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idegtiarenko
added
>non-issue
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
idegtiarenko
force-pushed
the
remove_table_info
branch
from
efcd0f1 to
5f92ace
Compare
alex-spies
approved these changes
Apr 2, 2025
There was a problem hiding this comment.
Thanks @idegtiarenko !
This changes the notion of equality used wherever we had TableInfo before. I went over the usages and can't see anything where we depended on exact object identity for TableInfo instances - as seen in this PR, we mostly just unwrapped those and used the contained IndexPattern, anyway.
# Conflicts: # x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/session/EsqlCCSUtils.java
andreidan
pushed a commit
to andreidan/elasticsearch
that referenced
this pull request
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TableInfo is currently wrapping a single IndexPattern field.
This change replaces all usages of TableInfo with actual IndexPattern it stored.
This followups on #120797 (comment)