Migrate tests away from S3 SDK MD5DigestCalculatingInputStream
#126099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`S3BlobContainerRetriesTests` uses `MD5DigestCalculatingInputStream` from the AWS v1 SDK to compute a MD5 checksum, but this feature is not available in the v2 SDK. With this commit we remove this dependency and compute the MD5 checksums directly instead.
DaveCTurner
added
>test
elasticsearchmachine
added
the
Team:Distributed Coordination
Collaborator
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
DaveCTurner
added
the
auto-backport
DiannaHohensee
approved these changes
Apr 2, 2025
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Apr 3, 2025
`S3BlobContainerRetriesTests` uses `MD5DigestCalculatingInputStream` from the AWS v1 SDK to compute a MD5 checksum, but this feature is not available in the v2 SDK. With this commit we remove this dependency and compute the MD5 checksums directly instead. Backport of elastic#126099 to `8.x`
Contributor
Author
|
Backport is #126214 |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 3, 2025
…6214) * Migrate tests away from S3 SDK `MD5DigestCalculatingInputStream` `S3BlobContainerRetriesTests` uses `MD5DigestCalculatingInputStream` from the AWS v1 SDK to compute a MD5 checksum, but this feature is not available in the v2 SDK. With this commit we remove this dependency and compute the MD5 checksums directly instead. Backport of #126099 to `8.x` * CI poke
andreidan
pushed a commit
to andreidan/elasticsearch
that referenced
this pull request
Apr 9, 2025
…stic#126099) `S3BlobContainerRetriesTests` uses `MD5DigestCalculatingInputStream` from the AWS v1 SDK to compute a MD5 checksum, but this feature is not available in the v2 SDK. With this commit we remove this dependency and compute the MD5 checksums directly instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
S3BlobContainerRetriesTestsusesMD5DigestCalculatingInputStreamfrom the AWS v1 SDK to compute a MD5 checksum, but this feature is not
available in the v2 SDK. With this commit we remove this dependency and
compute the MD5 checksums directly instead.