Fork per-node query action to search_coordination pool #126209
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The runtime of this action can heavily depend on the number of shards queried, how quickly queries execute and how likely the can_match we execute during the query phase is to return `false`. As we shouldn't have O(n) cost tasks that may run unpredictably long, lets fork this to search_coordination like we do for can_match and field_caps which both have similar runtime cost.
original-brownbear
added
>non-issue
:Search Foundations/Search
elasticsearchmachine
added
the
Team:Search Foundations
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
drempapis
reviewed
Apr 11, 2025
server/src/main/java/org/elasticsearch/action/search/SearchQueryThenFetchAsyncAction.java
Show resolved
Hide resolved
Contributor
Author
|
Thanks for taking a look @drempapis! It turns out that thanks to merging another PR we can now do even better here, I opened #127317 which takes this cahnge one step further :) I'll close here, we can go straight to that one now I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The runtime of this action can heavily depend on the number of shards queried, how quickly queries execute and how likely the can_match we execute during the query phase is to return
false. As we shouldn't have O(n) cost tasks that may run unpredictably long, let's fork this to search_coordination like we do for can_match and field_caps which both have similar runtime cost.