Skip to content

Conversation

@albertzaharovits
Copy link
Contributor

The test might produce over-budget tasks that cannot run even if all the other tasks that were blocked (and hold up budget) while running complete.
Rather than prevent submitting such over-budget tasks, this fix simply sets the merge task's queue available budget to Long.MAX_VALUE, in order to ensure that all merge tasks run before the test ends.

Fixes #129148
Backport of #130001

…tBlocksNewMergeTasksFromStartingExecution (elastic#130001)

The test might produce over-budget tasks that cannot run even if all the
other tasks that were blocked (and hold up budget) while running
complete. Rather than prevent submitting such over-budget tasks, this
fix simply sets the merge task's queue available budget to
`Long.MAX_VALUE`, in order to ensure that all merge tasks run before the
test ends.

Fixes elastic#129148
@albertzaharovits albertzaharovits self-assigned this Jun 26, 2025
@albertzaharovits albertzaharovits requested review from a team as code owners June 26, 2025 12:19
@albertzaharovits albertzaharovits added >test Issues or PRs that are addressing/adding tests :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. backport v9.0.4 labels Jun 26, 2025
@albertzaharovits albertzaharovits changed the base branch from main to 9.0 June 26, 2025 12:19
@albertzaharovits albertzaharovits changed the title [9.0] Fix ThreadPoolMergeExecutorServiceDiskSpaceTests testUnavailableBudgetBlocksNewMergeTasksFromStartingExecution [CI] [9.0] Fix ThreadPoolMergeExecutorServiceDiskSpaceTests testUnavailableBudgetBlocksNewMergeTasksFromStartingExecution Jun 26, 2025
@albertzaharovits albertzaharovits added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Jun 26, 2025
@elasticsearchmachine elasticsearchmachine merged commit ccdb22f into elastic:9.0 Jun 26, 2025
19 checks passed
@albertzaharovits albertzaharovits deleted the backport-90-fix-129148-take2 branch June 26, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. >test Issues or PRs that are addressing/adding tests v9.0.4

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] ThreadPoolMergeExecutorServiceDiskSpaceTests testUnavailableBudgetBlocksNewMergeTasksFromStartingExecution failing

2 participants