Add stats parameter support to count API #132963
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds support for the 'stats' parameter to the count API, providing feature parity with the search API. The stats parameter allows tagging count requests for logging and statistical purposes. Changes: - Added stats parameter parsing in RestCountAction - Updated count.json API specification to include stats parameter - Added comprehensive unit tests for stats parameter functionality The implementation follows the existing pattern used in RestSearchAction, passing the stats parameter through to the underlying SearchSourceBuilder. Closes elastic#67528 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
elasticsearchmachine
added
needs:triage
gareth-ellis
added
:Core/Infra/REST API
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
gareth-ellis
added
>enhancement
and removed
Team:Core/Infra
ldematte
added
:Search Foundations/Search
elasticsearchmachine
added
the
Team:Search Foundations
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
javanna
reviewed
Aug 18, 2025
Member
javanna
left a comment
javanna
left a comment
There was a problem hiding this comment.
Thanks for opening this PR, I left one comment on testing, the change itself looks good.
| import static org.hamcrest.Matchers.hasItems; | ||
| import static org.mockito.Mockito.mock; | ||
|
|
||
| public final class RestCountActionTests extends RestActionTestCase { |
Member
There was a problem hiding this comment.
I wonder if we should rather add a yaml test for this. The outcome is very similar. Yet the yaml tests are also run by clients and help verify that the new parameter is support by clients too (and not only by ES)
Member
|
test this please |
Member
|
Hello @natea are you interested in getting this merged? I reviewed this a while back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for the
statsparameter to the count API, providing feature parity with the search API. The stats parameter allows tagging count requests for logging and statistical purposes.Changes
RestCountAction.javacount.jsonAPI specification to include stats parameterRestCountActionTests.javaImplementation Details
The implementation follows the existing pattern used in
RestSearchAction, passing the stats parameter through to the underlyingSearchSourceBuilder. Since the count API internally uses the search API infrastructure, this was a straightforward addition requiring minimal code changes.Testing
Related Issue
Closes #67528
🤖 Generated with Claude Code