Fix disk usage estimation for SORTED_SET doc values. #133722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
|
Hi @martijnvg, I've created a changelog YAML for you. |
kkrik-es
approved these changes
Aug 28, 2025
felixbarny
approved these changes
Aug 28, 2025
|
bwc tests are failing because pf an unrelated issue: |
The `nextOrd()` was never invoked, which can hugely underestimate bytes used for doc sorted set doc values.
martijnvg
force-pushed
the
fix_IndexDiskUsageAnalyzer
branch
from
94ad512 to
58ae4bd
Compare
JeremyDahlgren
pushed a commit
to JeremyDahlgren/elasticsearch
that referenced
this pull request
Aug 29, 2025
The `nextOrd()` was never invoked, which can hugely underestimate bytes used for doc sorted set doc values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
nextOrd()was never invoked, which can hugely underestimate bytes used for doc sorted set doc values.