Fix: ESGpuHnswVectorsWriter#mergeOneField now supports non memory-mapped inputs
#134310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldematte
added
>non-issue
:Search Relevance/Vectors
elasticsearchmachine
added
the
Team:Search Relevance
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
ldematte
commented
Sep 8, 2025
x-pack/plugin/gpu/src/main/java/org/elasticsearch/xpack/gpu/codec/ESGpuHnswVectorsWriter.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/gpu/src/main/java/org/elasticsearch/xpack/gpu/codec/ESGpuHnswVectorsWriter.java
Show resolved
Hide resolved
x-pack/plugin/gpu/src/main/java/org/elasticsearch/xpack/gpu/codec/ESGpuHnswVectorsWriter.java
Show resolved
Hide resolved
x-pack/plugin/gpu/src/main/java/org/elasticsearch/xpack/gpu/codec/ESGpuHnswVectorsWriter.java
Show resolved
Hide resolved
x-pack/plugin/gpu/src/main/java/org/elasticsearch/xpack/gpu/codec/ESGpuHnswVectorsWriter.java
Outdated
Show resolved
Hide resolved
mayya-sharipova
approved these changes
Sep 8, 2025
There was a problem hiding this comment.
@ldematte Thanks, very nice refactoring.
I've left some comments to address, but otherwise LGTM
phananh1010
added a commit
to phananh1010/elasticsearch
that referenced
this pull request
Sep 23, 2025
BASE=42eff309f995e4484b93094ef347e05d6dc30bb3 HEAD=8b4d8c6f8fbfa3bb06b7b167f7b416a2c8c5dfe3 Branch=es-gpu
phananh1010
added a commit
to phananh1010/elasticsearch
that referenced
this pull request
Oct 8, 2025
BASE=42eff309f995e4484b93094ef347e05d6dc30bb3 HEAD=8b4d8c6f8fbfa3bb06b7b167f7b416a2c8c5dfe3 Branch=es-gpu
phananh1010
added a commit
to phananh1010/elasticsearch
that referenced
this pull request
Oct 17, 2025
BASE=42eff309f995e4484b93094ef347e05d6dc30bb3 HEAD=8b4d8c6f8fbfa3bb06b7b167f7b416a2c8c5dfe3 Branch=es-gpu
phananh1010
added a commit
to phananh1010/elasticsearch
that referenced
this pull request
Oct 23, 2025
BASE=42eff309f995e4484b93094ef347e05d6dc30bb3 HEAD=8b4d8c6f8fbfa3bb06b7b167f7b416a2c8c5dfe3 Branch=es-gpu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #134048
Separate two different paths/conditions: a) the vector size is too small, so we generate a mock graph (on the CPU) and b) the vector data file is not mmappable (e.g. filter or network FS), and so we fall back to alternative read methods.