[9.2] Bugfix/disable matches highlight knn (#136563) #136609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Disable matches mode for all knn queries matches highlight mode will utilize a MemoryIndex. Newer knn queries utilize an optimization that makes assumptions about the IndexSearch and reader utilized. This will end up throwing an NPE. While we have fixed this NPE in Apache Lucene, we just should not utilize weight matches model for knn queries at all. Maybe this restriction can be addressed later. closes: elastic#136427 * adding comment * formatting * Update docs/changelog/136563.yaml
benwtrent
added
:Search Relevance/Vectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 9.2: